updating how simple lightbox finds captions

https://stellarwp.atlassian.net/browse/KAD-3672
stellarwp · Dec 6, 2024 · 9275300 · 9275300
1 parent 049647e
commit 9275300
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/includes/assets/js/simplelightbox.min.js b/includes/assets/js/simplelightbox.min.js
diff --git a/src/assets/js/simplelightbox.js b/src/assets/js/simplelightbox.js
@@ -116,7 +116,19 @@
 			if (elements) {
 				elements.forEach(function (element, index) {
 					self.items.push(element.getAttribute(options.urlAttribute));
-					self.captions.push(element.getAttribute(options.captionAttribute));
+
+					//look for a caption in various spots
+					var caption = element.getAttribute(options.captionAttribute);
+					if (!caption) {
+						//try to find the title attribute on the underlying image
+						caption = element.querySelector('img')?.getAttribute(options.captionAttribute);
+
+						if (!caption) {
+							//try to find an attached fig caption
+							caption = element.parentElement?.querySelector('figcaption')?.textContent;
+						}
+					}
+					self.captions.push(caption);
 
 					if (options.bindToItems) {
 						self.addEvent(