soroban rpc make requires cargo for preflight step

[sreuland]

started seeing build errors from make build, noticed soroban-rpc requires using its makefile now, there are multiple steps involved in building it that have to be followed.

updated quickstart make and gh workflow to use intermediate dockerfile to run the soroban rpc make.

[tsachiherman]

I think that I understand the problem - but why wouldn't you update the docker in the soroban-tools ? I.e. keep the docker and the code in the same repo, so the hash remain the same.

[leighmcculloch]

The goal is to keep the dockerfiles in the respective repos, so ideally we'd update the dockerfile in the soroban-rpc repo so that it can successfully build the entire product instead of duplicating build process here.

Is there a reason we need the file here?

(Note that we do have a horizon file here, but that's only because we couldn't update the horizon file for a past release. Well switch back to the horizon repos file in a future version of quickstart.)

[sreuland]

yes, I saw the Horizon dockerfile, and seemed like a pattern to follow, @tsachiherman mentioned same - #415 (comment)

so, looks like I'll fix this from the soroban-tools side instead, closing this pr then.

[sreuland]

did the equivalent change on the soroban-tools dockerfile - stellar/stellar-cli#371

[sreuland]

I think that I understand the problem - but why wouldn't you update the docker in the soroban-tools ? I.e. keep the docker and the code in the same repo, so the hash remain the same.

@tsachiherman , I wasn't sure on usage for that Dockerfile, it has some integration setup as it's installing core from debian pkg, is the file deprecated? I could repurpose that, would have to remove the core install, won't work on an arm64 machine.

There's some precedence here for integrating as a client to the external build in a local docker such as Dockerfile.horizon does also, taking similar approach, setting host machine requirements in docker to run the makefile. One other aspect I was curious about is if Cargo.lock target in that makefile could check if rust toolchain exists first and install that if not?

I think we'll need to also apply a similar environment change to have rust toolchain present in pipeline for the soroban-rpc-package-builder.