soroban-rpc: remove dependency on Horizon

[2opremio]

soroban-rpc no longer depends on Horizon and thus we shouldn't be passing a horizon URL to soroban-rpc (thus --horizon-url= is no longer supported. This fixes part of stellar/stellar-cli#409)

Also, soroban-rpc no longer uses a submission queue for sending transactions (thus, --tx-queue= and --tx-concurrency= are no longer supported)

I am not sure when would it be safe to merge this though, since these changes were just recentely merged in the main branch of https://github.com/stellar/soroban-tools and this chart seems to depend on satyamz/soroban-rpc which I guess @satyamz should build and push.

[satyamz]

satyamz/soroban-rpc which I guess @satyamz should build and push.

@2opremio That was a temporary arrangement, we should use stellar/soroban-rpc image, We will create one if it doesn't exist.

[2opremio]

What Dockerfile was it created from?

[2opremio]

OK, it seems we should be using https://github.com/stellar/soroban-tools/blob/main/cmd/soroban-rpc/docker/Dockerfile

However, the build does not seem to be automated in CI ( or is it somehow automated in our internal Jenkins @satyamz ? ) which is something we should probably do at some point (CC @tsachiherman )

For now, I did the honors and built->pushed 2opremio/soroban-rpc:6dc54bd (using commit stellar/stellar-cli@6dc54bd ) as follows:

soroban-tools % docker build --build-arg STELLAR_CORE_VERSION='19.7.1-1204.871accefc.focal~soroban' --platform linux/amd64 -t 2opremio/soroban-rpc:6dc54bd -f cmd/soroban-rpc/docker/Dockerfile .

@satyamz PTAL

[tsachiherman]

OK, it seems we should be using https://github.com/stellar/soroban-tools/blob/main/cmd/soroban-rpc/docker/Dockerfile

However, the build does not seem to be automated in CI ( or is it somehow automated in our internal Jenkins @satyamz ? ) which is something we should probably do at some point (CC @tsachiherman )

For now, I did the honors and built->pushed 2opremio/soroban-rpc:6dc54bd (using commit stellar/soroban-tools@6dc54bd ) as follows:

soroban-tools % docker build --build-arg STELLAR_CORE_VERSION='19.7.1-1204.871accefc.focal~soroban' --platform linux/amd64 -t 2opremio/soroban-rpc:6dc54bd -f cmd/soroban-rpc/docker/Dockerfile .

@satyamz PTAL

I think that this should be the standalone soroban-rpc docker container that we should be working on this sprint. It should be invoked by the Quickstart repository and build there. Then, the helm chart repo can reference the latest built docker container. does that makes sense ?

[sreuland]

I think that this should be the standalone soroban-rpc docker container that we should be working on this sprint. It should be invoked by the Quickstart repository and build there. Then, the helm chart repo can reference the latest built docker container. does that makes sense ?

Correct, there is some overlap in scope here, we have a ticket to update the soroban-rpc dockerfile to enable the helm chart usage:
stellar/stellar-cli#418

we are starting on that, it will build an image ready for pulling into deployments(such as k8s) , the dockerfile will also be updated to configure captive core runtime in the container as rpc needs that now and it also will add a new gh workflow to soroban-tools repo, on tag/pr/release events to push new registry image for rpcstellar/soroban-rpc

so, can proceed with this update as-is, but it will be for brief amount of time, as a new pr will be submitted here once stellar/stellar-cli#418 is done, to change the helm to pull and config for stellar/soroban-rpc.

[2opremio]

Can I get an approval? We can update the image later

[satyamz]

@2opremio You need to remove 3 deprecated parameters from values.yaml too

[satyamz]

@2opremio

OK, it seems we should be using https://github.com/stellar/soroban-tools/blob/main/cmd/soroban-rpc/docker/Dockerfile

Yes. I just figured it out, that's correct Dockerfile.

or is it somehow automated in our internal Jenkins @satyamz ?

No. We do not have build job for this.

[satyamz]

@tsachiherman

I think that this should be the standalone soroban-rpc docker container that we should be working on this sprint. It should be invoked by the Quickstart repository and build there.

I did not understand relation between quickstart repository and soroban-rpc image build. Can you please elaborate this? Do you mean we should build soroban-rpc whenever there's a change in quickstart repo?

[2opremio]

@2opremio You need to remove 3 deprecated parameters from values.yaml too

Done!