Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve rds status check #6

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

stefanfreitag
Copy link
Owner

Fixes #4

- Added __pycache__/ to ignore Python bytecode
- Refactored the code to move the logic for getting valid states into a separate function `get_valid_states()`.
- Updated the `lambda_handler()` function to use the `get_valid_states()` function instead of directly accessing the environment variable.
- Added a new unit test file `test_index.py` to test the `get_valid_states()` function.
- The new unit test verifies that `get_valid_states()` returns a list of valid states, including any additional states specified in the environment variable "SUPPRESS_STATES".
@stefanfreitag stefanfreitag linked an issue Nov 23, 2023 that may be closed by this pull request
@stefanfreitag stefanfreitag added the enhancement New feature or request label Nov 23, 2023
@stefanfreitag stefanfreitag merged commit ae1f0cf into main Nov 23, 2023
4 checks passed
@stefanfreitag stefanfreitag deleted the 4-improve-rds-status-check branch November 23, 2023 21:15
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve RDS status check
2 participants