Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ feature ] New Pack Command: Uninstall #299

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

Matthew-Mosior
Copy link
Contributor

@Matthew-Mosior Matthew-Mosior commented Aug 2, 2024

This PR adds a new pack command uninstall, which can be invoked as follows:

$ pack uninstall

This pack command deletes the $PACK_DIR.

This PR closes #294.

@buzden
Copy link
Collaborator

buzden commented Aug 3, 2024

Looks good, but I would expect pack printing it's currently configured $PACK_DIR and prompting that removing it (including user's config there) is indeed user's intention.

@Matthew-Mosior
Copy link
Contributor Author

Looks good, but I would expect pack printing it's currently configured $PACK_DIR and prompting that removing it (including user's config there) is indeed user's intention.

Sounds good, I’ll go ahead and address this!

@Matthew-Mosior
Copy link
Contributor Author

Looks good, but I would expect pack printing it's currently configured $PACK_DIR and prompting that removing it (including user's config there) is indeed user's intention.

This should be addressed via 6090c48.

src/Pack/Runner/Uninstall.idr Outdated Show resolved Hide resolved
src/Pack/Runner.idr Outdated Show resolved Hide resolved
src/Pack/Runner/Uninstall.idr Outdated Show resolved Hide resolved
@buzden buzden merged commit ea82fc7 into stefan-hoeck:main Aug 13, 2024
7 checks passed
@Matthew-Mosior Matthew-Mosior deleted the feature-addition-uninstall branch August 13, 2024 14:12
@buzden buzden added the enhancement New feature or request label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official Way To Automatically Uninstall
3 participants