Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Database Signal Interface #2230

Closed
mvandeberg opened this issue Mar 14, 2018 · 0 comments
Closed

Clean Up Database Signal Interface #2230

mvandeberg opened this issue Mar 14, 2018 · 0 comments
Labels

Comments

@mvandeberg
Copy link
Contributor

To implement #1996, #2149 changed the interface for plugins registering with a signal to save the name for statistics collecting.

Each plugin has a name() method already, that should be used here. Instead of creating a proxy method, which isn't well documented and confusing when the signal is still exposed, I suggest creating a macro PLUGIN_REGISTER_SIGNAL( signal, method ) that calls the appropriate method in the database, creates the lamba properly, etc. This will also allow use of name(), so the correct name is always registered and is a much cleaner interface.

The group can also be exposed by the macro. It should still return the connection object to be stored in the plugin itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants