Additional Spacing in Header on Mobile Devices #3918
Comments
the-gorilla-steem
added a commit
to the-gorilla-steem/condenser
that referenced
this issue
Jun 6, 2024
This bug was preventing the navigation displaying correctly on mobile devices so needed fixing as part of #proposal-86. The chosen solution was to change the method of showing/hiding items to use "display" instead of "visibility". This meant that everything looks the same but the underlying method is different. I also removed an unnecessary parameter when accessing the previousUrl from localStorage.
yuekun0707
pushed a commit
that referenced
this issue
Aug 5, 2024
* Updated Profile Navigation Menu Added @username's Feed alongside "Wallet" and "Settings" on the right of the Navigation bar. Also implemented "My Feed" for when a user is logged in which is currently commented out. * Top Navigation Implementation Archiving the version of the restyled navigation menu that positions it at the top of the screen. * Revert "Top Navigation Implementation" This reverts commit d246aa9. * Revert "Updated Profile Navigation Menu" This reverts commit b112f20. * Introduction of Primary Navigation These changes introduce a Primary Navigation across the site. The navigation uses an "App Style", bottom tab structure on mobile devices and a more traditional left navigation for Desktop. Full details of the changes are available in the following Steemit posts: Updated Files: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-edited-files New Navigation Component: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-primarynavigation-jsx-and-scss * Bug Fix Fixed a bug for logged out users on a mobile device. They would see an empty secondary navigation under the "Explore" tab. * Performance & Display Tweak Performance: Moved the windowHeight and navHeight calculations into the "Desktop only" scroll section. Display: Tweaked the calculations to improve how the navigation is pinned when taller than the screenHeight. Swapped the "Posts" and "Blog" labels so that "Blog" appears before "Posts" in the Profile Menu. * Spacing Adjustment Adjusted the spacing between icons and their labels. * Hidden "Load More..." Where the "Load more..." link appears on the Notifications screen, it was hidden behind the 2nd level of navigation on Mobile Devices. Additional padding has been introduced to correct this. * Bug Fix Fixed the following issue: 1. Go to your test site or steemitdev 2. Logout 3. Go to the top-level page (or just reload the page?) 4. Login 5. A list of communities gets displayed under, "My Subscriptions", but the communities are not the ones that I subscribe to. The subscriptions were only loaded upon "componentWillMount" with a log in not constituting a remount. Therfore, if the subscriptions have not been set, they should be set upon a componentDidUpdate instead / as well. * Improved Previous Bug Fix Used componentDidUpdate in previous bug fix where componentWillUpdate will give an improved user experience (i.e. with DidUpdate, the "Trending Subscriptions" flashed up before being updated whereas "WillUpdate" has the update prepared. * Revert "Improved Previous Bug Fix" This reverts commit 8259147. * #3918 Bug Fix This bug was preventing the navigation displaying correctly on mobile devices so needed fixing as part of #proposal-86. The chosen solution was to change the method of showing/hiding items to use "display" instead of "visibility". This meant that everything looks the same but the underlying method is different. I also removed an unnecessary parameter when accessing the previousUrl from localStorage. --------- Co-authored-by: the-gorilla-steem <[email protected]>
the-gorilla-steem
added a commit
to the-gorilla-steem/condenser
that referenced
this issue
Oct 1, 2024
Adjusted the position of the Avatar Menu on mobile devices so that when opened on Android phones, the Primary Navigation remains visible. This is an additional fix to bug steemit#3918.
ety001
pushed a commit
that referenced
this issue
Nov 19, 2024
* #3915 Bug Fix Addition of overflow-wrap property to h1 element so that words longer than the display area are forced to wrap instead of being completely hidden. * Fixed Bug #3911 This issue also applied when trying to downvote a post at the end of a user's feed and in all other scenarios where the downvote button appears towards the bottom of the screen. Upvote overlay has a "top: -30px" set so this implementation was replicated with a "top" of -270px for the downvote overlay. 270px was chosen as it allows for the contents of the overlay to be visible when at downvoting the first and last post in a feed. A margin-left of -36px was added so that the close 'X' button is visible on mobile devices. (left did not work due to 'left: 0%' being set in the Dropdown.scss file. * Avatar Menu Position on Mobile Devices Adjusted the position of the Avatar Menu on mobile devices so that when opened on Android phones, the Primary Navigation remains visible. This is an additional fix to bug #3918. * Reintroduction of "Hot" Menu Option Fix for bug #3919 to reintroduce "Hot" Menu Option alongside "Trending", "New", etc. * Fixed Table Layout Fixed bug #3924 by introducing a scrollbar underneath tables that exceed their wrapper width. * Introduced Navigation Toggle To solve some visibility issues that are predominantly on Android devices (bug #3923 ), a show/hide navigation toggle has been introduced on Mobile Devices. More details regarding these changes can be found in this post - https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-bugs-3911-3915-3918-3919-3923-3924 * Community Carousel Introduction of a carousel for Pinned Posts, allowing the user to collapse all pinned posts into a more condensed view via a toggle. For more information, please read this post - https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-community-pinned-posts * Removed Comments Deleted commented out styles that were used for debugging. * New Community Banner Implemented a configurable banner for each community. These can be set within the Community's Settings. More detail can be found here - https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-community-banner-and-settings * Translations for Communities Introduced translations for the community pages - Main page, banner, subscribe button and settings. * Additional Translation Included additional translation for Show / Collapse Pinned posts. * Pinned Posts Fix Adjusted the pinned posts display so that when the "minimised state" is stored and then posts are unpinned, it reverts to the list view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When browsing the site on a mobile, if the user scrolls to the top of the screen, a bottom scrollbar appears. This is due to some additional space appearing to the right of the viewing area.
When scrolling down, this white space disappears, as does the scrollbar.
The text was updated successfully, but these errors were encountered: