Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#114] Config.extraInfo now optional #119

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

ssawchenko
Copy link
Collaborator

@ssawchenko ssawchenko commented Aug 1, 2023

Related Issue: #114

Summary of Problem:

When I added the extra info config param I made it non optional, which isn't always desired.

Proposed Solution:

Made property optional

Testing Steps:

To do this I have added a checkbox in the sample app that toggles between setting the property, and having it be set to null.

  1. Go to sample app Sentry board https://steamclock-software.sentry.io/issues/?project=5399932 and delete all issues
  2. Open sample app and set log level to Release (make sure "add extra config info" checkbox is NOT checked)
  3. Press "Send User Report" button
  4. Check "add extra config info"
  5. Press "Send User Report" button again
  6. Go to Sentry board (sometimes you have to wait a few seconds or refresh the board to get the issues to appear)
  7. Make sure that there are two issues and that the "newest" issue contains the additional data section, but the oldest issue does not:
    Screenshot 2023-08-01 at 12 13 48 PM

@ssawchenko ssawchenko changed the title [WIP] [#114] Config.extraInfo now optional [#114] Config.extraInfo now optional Aug 14, 2023
@ssawchenko ssawchenko requested a review from phileo August 14, 2023 18:30
Copy link

@phileo phileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looks good 👍

@ssawchenko ssawchenko assigned ssawchenko and unassigned phileo Aug 15, 2023
@ssawchenko ssawchenko merged commit 4290472 into main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants