Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#111] Added info to avoid Sentry duplications (due to 3rd party Timber integration) #112

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

ssawchenko
Copy link
Collaborator

Related Issue: #111

Summary of Problem:

https://docs.sentry.io/platforms/android/configuration/integrations/timber/

Starting from version 3.1.0, the Sentry Android Gradle plugin will automatically add the sentry-android-timber dependency. The plugin will only add the sentry-android-timber dependency if a timber dependency was discovered on the classpath.

This will cause our errors to be duplicated in Sentry.

Proposed Solution:

  • Unfortunately the actual fix will have to be done in each of our client app's gradle files, however, this PR documents the required changes in the PR and shows how to do it in the sample app
  • I have also updated the sample app a little to make it easier to test out sending only a single error (which makes testing duplication much easier)

Testing Steps:

  1. Go to the Sentry page for the sample app: https://steamclock-software.sentry.io/issues/?project=5399932
  2. Select all of the issues in the list and select the "Resolve" button; this should clear the list of errors and make it easy to see new ones coming in.
  3. Run the sample app, and change the log level at the top to Release
  4. Press the "Report Single Error" button
  5. Wait ~10seconds (sometimes it may take longer to send the report to Sentry)
  6. Refresh the Sentry page
  7. Make sure you only see 1 error reported in Senty:
    image

…try integration

* Updated sample app to allow us to send one error (previously could only send multiple)
Copy link

@phileo phileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍

@ssawchenko ssawchenko merged commit 16436ff into main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants