Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[73] Add more helpful decoding error descriptions #85

Merged
merged 6 commits into from
Aug 26, 2021
Merged

[73] Add more helpful decoding error descriptions #85

merged 6 commits into from
Aug 26, 2021

Conversation

jenncoop
Copy link
Member

Fixes #73

Adds more helpful decoding error descriptions so decoding errors are easier to debug.

Before:

Screen Shot 2021-08-26 at 9 25 03 AM

After:

Screen Shot 2021-08-26 at 9 32 07 AM

brendanlensink
brendanlensink approved these changes Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@brendanlensink brendanlensink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀

@jenncoop jenncoop assigned jenncoop and unassigned nbrooke and brendanlensink Aug 26, 2021
@jenncoop jenncoop merged commit e052ae9 into master Aug 26, 2021
@jenncoop jenncoop deleted the jlc/73-improve-decoding-error-messaging branch August 26, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanlensink brendanlensink brendanlensink approved these changes

@nbrooke nbrooke nbrooke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve decoding error messaging
3 participants
@jenncoop @nbrooke @brendanlensink