Comment away react-native-screens #8868

vitvly · 2019-08-29T13:28:20Z

Temporarily comments away react-native-screens for Android.

#8708 might be caused by software-mansion/react-native-screens#54

ghost · 2019-08-29T13:28:26Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-08-29T13:39:48Z

Jenkins Builds

Click to see older builds (7)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c3ff1cb`	#1	2019-08-29 13:39:48	~11 min	`android-e2e`	📦 apk
✔️	`c3ff1cb`	#1	2019-08-29 13:39:58	~11 min	`ios`	📦 ipa
✔️	`c3ff1cb`	#1	2019-08-29 13:44:56	~16 min	`android`	📦 apk

✔️	`676f937`	#2	2019-08-30 07:19:07	~11 min	`android`	📦 apk
✔️	`676f937`	#2	2019-08-30 07:19:14	~11 min	`ios`	📦 ipa
✔️	`676f937`	#2	2019-08-30 07:20:58	~13 min	`android-e2e`	📦 apk
❌	`676f937`	#3	2019-09-04 18:14:17	~26 sec	`ios`	📄 log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`3d70cc0`	#4	2019-09-05 09:42:24	~7 min	`ios`	📄 log
✔️	`3d70cc0`	#3	2019-09-05 09:45:37	~10 min	`android-e2e`	📦 apk
✔️	`3d70cc0`	#3	2019-09-05 09:46:56	~11 min	`android`	📦 apk

❌	`71b0c4b`	#5	2019-09-05 10:02:21	~7 min	`ios`	📄 log
✔️	`71b0c4b`	#4	2019-09-05 10:05:10	~10 min	`android-e2e`	📦 apk
✔️	`71b0c4b`	#4	2019-09-05 10:07:24	~12 min	`android`	📦 apk
❌	`71b0c4b`	#6	2019-09-05 15:33:40	~9 min	`ios`	📄 log
✔️	`71b0c4b`	#7	2019-09-05 15:53:33	~11 min	`ios`	📦 ipa

yenda · 2019-09-05T09:03:12Z

Looks like it is not up to date, btw the issue you link mentions that moving useScreen to component-did-mount can potentially fix things is that the case now that it has been done?

vitvly · 2019-09-05T09:08:24Z

@yenda haven't tried that approach as it wasn't consistently working for everyone.

yenda · 2019-09-05T09:08:44Z

@siphiuel I just checked and moving it to component-did-mount didn't fix it so it looks like this fix is needed. Please add a TODO before the comment

yenda · 2019-09-05T09:46:51Z

src/status_im/android/core.cljs

@@ -43,7 +43,8 @@
                        (when-not (zero? @keyboard-height)
                          (dispatch [:set :keyboard-height 0]))))
        (.hide react/splash-screen)
-        (.useScreens rn-dependencies/react-native-screens)
+        ; TODO Temporarily comment away due to current bug https://github.com/kmagiera/react-native-screens/issues/54


use double ; for comments

statustestbot · 2019-09-05T10:06:54Z

89% of end-end tests have passed

Total executed tests: 45
Failed tests: 5
Passed tests: 40

Failed tests (5)

Click to expand

1. test_deploy_contract_from_daap
Device 1: Tap on OkButton Device 1: Looking for an element by text: 'Contract deployed at: ' `Contract was not created` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_add_account_to_multiaccount_instance
Device 1: Tap on AddAccountButton Device 1: Tap on AddAnAccountButton `Device 1: 'GenerateNewAccountButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_long_press_to_delete_public_chat
Device 1: Looking for a message by text: 'test message' Device 1: Wait for ChatElementByText `Chat history is shown` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_backup_recovery_phrase
Device 1: Tap on OkContinueButton Device 1: Tap on NextButton `10` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_backup_recovery_phrase_warning_from_wallet
Device 1: Wait for BackupRecoveryPhrase Device 1: Wait for BackupRecoveryPhrase `Device 1: 'BackupRecoveryPhrase' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (40)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
6. test_public_chat_messaging
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
7. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
8. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
9. test_text_message_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
10. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
12. test_unread_messages_counter_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
13. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
14. test_send_message_in_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
15. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
16. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
17. test_offline_messaging_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
18. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
19. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
20. test_manage_assets
Device sessions Device 1: Steps, video, logs
21. test_send_emoji
Device sessions Device 1: Steps, video, logs
22. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
23. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
24. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
25. test_messaging_in_different_networks
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
26. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
27. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
28. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
29. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
30. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
31. test_add_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
33. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
34. test_offline_status
Device sessions Device 1: Steps, video, logs
35. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
36. test_unread_messages_counter_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
37. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
38. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
39. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
40. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs

jakubgs · 2019-09-05T15:54:10Z

The iOS signing issue has been fixed, so the build is green.

Serhy · 2019-09-06T11:28:02Z

Can't reproduce initial issue #8708 anymore with Android 6.0.1, 8.1, 9
Everything is ok with the chats and navigation through major screens (creating public chat, messaging, put app background->enable 3G connection -> app foreground = bottom sheet appears, etc)
Failed tests are not this PR issue and retested to confirm they are pass.

Signed-off-by: yenda <[email protected]>

vitvly requested a review from a team as a code owner August 29, 2019 13:28

auto-assign bot removed the request for review from a team August 29, 2019 13:28

vitvly self-assigned this Aug 29, 2019

vitvly mentioned this pull request Aug 29, 2019

App crash when open Status after it was put on background with Android hardware 'Back' button #8708

Closed

vitvly requested review from flexsurfer and yenda August 29, 2019 14:21

vitvly force-pushed the fix/8708-app-crash-on-back branch from c3ff1cb to 676f937 Compare August 30, 2019 07:07

flexsurfer approved these changes Sep 2, 2019

View reviewed changes

vitvly force-pushed the fix/8708-app-crash-on-back branch from 676f937 to 3d70cc0 Compare September 5, 2019 09:34

yenda reviewed Sep 5, 2019

View reviewed changes

vitvly force-pushed the fix/8708-app-crash-on-back branch from 3d70cc0 to 71b0c4b Compare September 5, 2019 09:54

yenda approved these changes Sep 5, 2019

View reviewed changes

Serhy added the Tested - OK label Sep 6, 2019

Comment away screens

93b8fa0

Signed-off-by: yenda <[email protected]>

yenda force-pushed the fix/8708-app-crash-on-back branch from 71b0c4b to 93b8fa0 Compare September 6, 2019 12:48

yenda merged commit 93b8fa0 into develop Sep 6, 2019

delete-merged-branch bot deleted the fix/8708-app-crash-on-back branch September 6, 2019 12:48

vitvly mentioned this pull request Oct 1, 2019

Android app crashes if moved to foreground after running on background for some time (several hours or a night) #8564

Closed

vitvly mentioned this pull request Mar 20, 2020

Use community WebView #10090

Merged

StatusWrike unassigned vitvly Apr 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comment away react-native-screens #8868

Comment away react-native-screens #8868

vitvly commented Aug 29, 2019 •

edited by StatusWrike

Loading

ghost commented Aug 29, 2019

status-im-auto commented Aug 29, 2019 •

edited

Loading

yenda commented Sep 5, 2019 •

edited

Loading

vitvly commented Sep 5, 2019

yenda commented Sep 5, 2019 •

edited

Loading

yenda Sep 5, 2019

vitvly Sep 5, 2019

statustestbot commented Sep 5, 2019

jakubgs commented Sep 5, 2019

Serhy commented Sep 6, 2019

Comment away react-native-screens #8868

Comment away react-native-screens #8868

Conversation

vitvly commented Aug 29, 2019 • edited by StatusWrike Loading

ghost commented Aug 29, 2019

Pull Request Checklist

status-im-auto commented Aug 29, 2019 • edited Loading

Jenkins Builds

yenda commented Sep 5, 2019 • edited Loading

vitvly commented Sep 5, 2019

yenda commented Sep 5, 2019 • edited Loading

yenda Sep 5, 2019

Choose a reason for hiding this comment

vitvly Sep 5, 2019

Choose a reason for hiding this comment

statustestbot commented Sep 5, 2019

89% of end-end tests have passed

Failed tests (5)

Passed tests (40)

jakubgs commented Sep 5, 2019

Serhy commented Sep 6, 2019

vitvly commented Aug 29, 2019 •

edited by StatusWrike

Loading

status-im-auto commented Aug 29, 2019 •

edited

Loading

yenda commented Sep 5, 2019 •

edited

Loading

yenda commented Sep 5, 2019 •

edited

Loading