Fix twitter share image #1441
Merged
Fix twitter share image #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-aac
requested review from
thecotne,
robwalsh21,
milosyuki,
lorcan-codes and
jopedroliveira
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
env is set from here https://github.com/starknet-io/starknet-website/blob/dev/.github/workflows/website.yml#L56 it needs to have a conditional for production |
nuno-aac
force-pushed
the
bugfix/fix-twitter-share
branch
from
1b29389 to
3b86015
Compare
nuno-aac
temporarily deployed
to
Netlify CMS bugfix/fix-twitter-share
GitHub Actions
Inactive
nuno-aac
temporarily deployed
to
Starknet Website bugfix/fix-twitter-share
GitHub Actions
Inactive
nuno-aac
temporarily deployed
to
Storybook bugfix/fix-twitter-share
GitHub Actions
Inactive
nuno-aac
force-pushed
the
bugfix/fix-twitter-share
branch
from
3b86015 to
1b7ea2a
Compare
nuno-aac
temporarily deployed
to
Netlify CMS bugfix/fix-twitter-share
GitHub Actions
Inactive
nuno-aac
temporarily deployed
to
Starknet Website bugfix/fix-twitter-share
GitHub Actions
Inactive
nuno-aac
temporarily deployed
to
Storybook bugfix/fix-twitter-share
GitHub Actions
Inactive
nuno-aac
force-pushed
the
bugfix/fix-twitter-share
branch
from
1b7ea2a to
2469816
Compare
rafaelcruzazevedo
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the issue with images in twitter sharing. This seems to be a deeper issue with the
VITE_SITE_URLenv variable pointing toproduction.starknet-website.pages.devinstead of the actual domain url. This domain is not actually getting the images uploaded to it since June. but they are present in the main domain. Since the environment is part of the infrastructure and i had trouble pinpointing where to set it, this solution should work as a stopgap measure until we figure out the big picture.