Merge pull request iluwatar#641 from dosdebug/fix_command_pattern

Removes unused size and visibility enumerations
stardustman · Sep 26, 2017 · 193879d · 193879d
2 parents 6848dd0 + c9f4048
commit 193879d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/command/src/main/java/com/iluwatar/command/Size.java b/command/src/main/java/com/iluwatar/command/Size.java
@@ -29,7 +29,7 @@
  */
 public enum Size {
 
-  SMALL("small"), NORMAL("normal"), LARGE("large"), UNDEFINED("");
+  SMALL("small"), NORMAL("normal");
 
   private String title;
 

diff --git a/command/src/main/java/com/iluwatar/command/Visibility.java b/command/src/main/java/com/iluwatar/command/Visibility.java
@@ -29,7 +29,7 @@
  */
 public enum Visibility {
 
-  VISIBLE("visible"), INVISIBLE("invisible"), UNDEFINED("");
+  VISIBLE("visible"), INVISIBLE("invisible");
 
   private String title;
 

diff --git a/command/src/main/java/com/iluwatar/command/Wizard.java b/command/src/main/java/com/iluwatar/command/Wizard.java
@@ -40,7 +40,9 @@ public class Wizard {
   private Deque<Command> undoStack = new LinkedList<>();
   private Deque<Command> redoStack = new LinkedList<>();
 
-  public Wizard() {}
+  public Wizard() {
+    // comment to ignore sonar issue: LEVEL critical
+  }
 
   /**
    * Cast spell