Prompt for reauth in case of 498 drop #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where users saw "Sync error: The provided access token has expired" in the footer without being asked to reauth. With this fix, users will now be asked to reauth.
To replicate this behavior, comment out these lines: https://github.com/standardnotes/app/blob/fix-498-drop/packages/api/src/Domain/Http/HttpService.ts#L173-L196
This tells us likely that one of the conditions in the
ifis not being met, such as the request being a refresh request (and thus the server perhaps responding with a 498 to a refresh request, which it should not do).