-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete beta_neg_binomial_lccdf test #3118
delete beta_neg_binomial_lccdf test #3118
Conversation
Instead of deleting it, can we try the following
The prob testing framework is mostly to ensure that all the different varations of scalars and vectors can go into the distributions. But if we just want to test boundaries and things like that then I think it would be better for us to have those in mix/prob testing folder |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Thanks to Steve's suggestion, after some debugging I found certain magic numbers and now the time for this test should be the same as other distributions. Let’s see how it works on the Jenkins machine. |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it is indeed much faster!
Summary
As described by #3117, disable the test for
beta_neg_binomial_lccdf
.Tests
NA
Side Effects
NA
Release notes
test/prob/beta_neg_binomial/beta_neg_binomial_ccdf_log_test.hpp
will be deleted if merged.Checklist
Copyright holder: Zhi Ling
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested