Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug inits tests #954

Closed
wants to merge 5 commits into from
Closed

debug inits tests #954

wants to merge 5 commits into from

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Apr 22, 2024

Don't merge this. Just additional tests related to #937 (comment) as discussed with @SteveBronder

@SteveBronder
Copy link
Collaborator

It looks like it failed because of something else?

@jgabry
Copy link
Member Author

jgabry commented Apr 22, 2024

It's just failing on R 3.6 because we're now requiring R 4.0. Just merged a PR into this one that should fix that. Aside from the check using R 3.6 I don't see any failures yet.

@jgabry
Copy link
Member Author

jgabry commented Apr 23, 2024

Ugh, same error. Really strange. Not sure what's going on.

https://github.com/stan-dev/cmdstanr/actions/runs/8790487616/job/24122605861#step:13:3310

── Failure ('test-fit-init-debug.R:61:3'): Pathfinder method with psis_resample as false works as init ──
Expected `test_inits(mod_logistic, fit_path_init, data_list_logistic)` to run without any errors.
ℹ Actually got a <simpleError> with text:
  Assertion on 'files' failed: File does not exist: '/tmp/RtmpNMWjuB/working_dir/RtmpIOmJZ0/logistic-202404222153-1-84d8fc.csv'.

@jgabry
Copy link
Member Author

jgabry commented Apr 24, 2024

@SteveBronder now it's passing everything here, but not sure if that's just because we got lucky (since the error seems nondeterministic). I will trigger the tests to run again.

@SteveBronder
Copy link
Collaborator

@jgabry I think I figured it out but it's very confusing. Removing the set.seed() in the file I changed above will allow let the while loop run forever instead of failing to generate the file. I don't know about about R internals to understand why that would be the issue though? but I've had it that while loop for 10 minutes now without issue

@andrjohns
Copy link
Collaborator

Closing as issue resolved

@andrjohns andrjohns closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants