Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document global options and add cmdstanr_output_dir #951

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Apr 17, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

both suggested by @avehtari

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry requested a review from avehtari April 17, 2024 18:02
@jgabry
Copy link
Member Author

jgabry commented Apr 17, 2024

The windows unit tests are failing due to unrelated issues with GitHub actions

Copy link
Contributor

@avehtari avehtari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about the directories

R/options.R Outdated Show resolved Hide resolved
R/options.R Outdated Show resolved Hide resolved
@jgabry
Copy link
Member Author

jgabry commented Apr 18, 2024

Thanks, I added that clarification in both cases

@jgabry jgabry merged commit 2980ca7 into master Apr 19, 2024
12 checks passed
@jgabry jgabry deleted the document-global-options branch April 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global option cmdstanr_output_dir List the supported global options
2 participants