Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coercion generics #943

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Added coercion generics #943

merged 1 commit into from
Apr 10, 2024

Conversation

gowerc
Copy link
Contributor

@gowerc gowerc commented Apr 2, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Please describe the purpose of the pull request:

Closes #938 (Implements generic coercion functions for downstream packages to use)

Note that on local testing I got the following warning:

Warning (test-fit-mle.R:55:3): no error when checking estimates after failure
Fitting finished unexpectedly! Use the $output() method for more information.

Considering I didn't change any existing code (I just added generics for others to use, shouldn't have any impact on existing functionality at all) assuming this is either (a) expected or (b) not something I need to worry about?

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
F. Hoffmann-La Roche AG

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.57%. Comparing base (1b45e70) to head (f7b6918).

❗ Current head f7b6918 differs from pull request most recent head c8d6492. Consider uploading reports for the commit c8d6492 to get more accurate results

Files Patch % Lines
R/generics.R 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
- Coverage   88.33%   86.57%   -1.76%     
==========================================
  Files          12       13       +1     
  Lines        4553     4560       +7     
==========================================
- Hits         4022     3948      -74     
- Misses        531      612      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gowerc
Copy link
Contributor Author

gowerc commented Apr 8, 2024

Just to say that I don't think test failures have anything to do with the code change. Please let me know though if there are things you'd like me to adjust though

@jgabry
Copy link
Member

jgabry commented Apr 10, 2024

Thanks! I agree that the failures are unrelated to this PR.

@jgabry
Copy link
Member

jgabry commented Apr 10, 2024

I'm going to go ahead and merge this since the failures are unrelated. Thanks again @gowerc!

@jgabry jgabry merged commit ced35d1 into stan-dev:master Apr 10, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export generic casting methods for downstream packages
3 participants