Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release of CmdStanR v0.7.0 #871

Merged
merged 22 commits into from
Dec 13, 2023
Merged

Prepare release of CmdStanR v0.7.0 #871

merged 22 commits into from
Dec 13, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 8, 2023

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Preparing for release of v0.7.0

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry changed the title Prep v0.7.0 Prepare release of CmdStanR v0.7.0 Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (bc60419) 88.46% compared to head (36f05d3) 88.36%.

❗ Current head 36f05d3 differs from pull request most recent head 9769e8c. Consider uploading reports for the commit 9769e8c to get more accurate results

Files Patch % Lines
R/fit.R 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   88.46%   88.36%   -0.11%     
==========================================
  Files          12       12              
  Lines        4517     4528      +11     
==========================================
+ Hits         3996     4001       +5     
- Misses        521      527       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgabry jgabry linked an issue Nov 8, 2023 that may be closed by this pull request
@avehtari
Copy link
Contributor

avehtari commented Dec 1, 2023

@jgabry can you update this PR with the latest commits in master? Specifically this PR fixes #872, but doesn't include PR #881 which fixes #770, so currently neither master nor this branch is working for me. Pinging also @andrjohns

@jgabry
Copy link
Member Author

jgabry commented Dec 5, 2023

@jgabry can you update this PR with the latest commits in master?

Sorry for the delay, should be updated from master now

@jgabry jgabry mentioned this pull request Dec 13, 2023
2 tasks
@jgabry
Copy link
Member Author

jgabry commented Dec 13, 2023

I think this is ready to go if the checks that are currently running pass. I'll check back a bit later to see if they were successful (they take a while to run).

@jgabry jgabry marked this pull request as ready for review December 13, 2023 20:14
@jgabry jgabry merged commit 8b4c2e3 into master Dec 13, 2023
12 checks passed
@jgabry jgabry deleted the prep-v0.7.0 branch December 13, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants