Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linux/wsl detection for install arch #856

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

The current install process only downloads the correct release tarball for non-x86_64 if the combination is Linux+arm64. This PR updates the detection to correctly handle other architectures on Linux and WSL

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #856 (7b18827) into master (17678d5) will decrease coverage by 0.20%.
The diff coverage is 50.00%.

❗ Current head 7b18827 differs from pull request most recent head 17e9ff9. Consider uploading reports for the commit 17e9ff9 to get more accurate results

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   88.19%   87.99%   -0.20%     
==========================================
  Files          12       12              
  Lines        4218     4233      +15     
==========================================
+ Hits         3720     3725       +5     
- Misses        498      508      +10     
Files Changed Coverage Δ
R/install.R 63.02% <47.61%> (-1.05%) ⬇️
R/utils.R 72.53% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrjohns andrjohns merged commit 7d3d6fa into master Sep 25, 2023
12 checks passed
@andrjohns andrjohns deleted the linux-arch-detection branch September 25, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants