Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change duplicate stdout_file to stderr_file #834

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Aug 23, 2023

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

closes #826

In .run_diagnose we were printing stdout twice instead of stdout one and stderr once.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry marked this pull request as ready for review August 23, 2023 16:46
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jgabry jgabry merged commit a13c798 into master Aug 24, 2023
12 checks passed
@jgabry jgabry deleted the diagnose-method-duplicate-stdout branch August 24, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output duplicated when running diagnose
2 participants