Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #1026: update repair_path() to work with network paths, add test. #1038

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

bschneidr
Copy link
Contributor

Submission Checklist

  • [ x] Run unit tests
  • [ x] Declare copyright holder and agree to license (see below)

Summary

Fixes issue #1026 by allowing repair_path() to work with network paths. Updates the unit test accordingly.

Copyright and Licensing

(I filled in my name since that's part of the issue template)

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):

Benjamin Schneider

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Unit Test Results

══ Results ═════════════════════════════════════════════════════════
Duration: 4639.4 s

── Skipped tests (13) ──────────────────────────────────────────────
• !mpi_toolchain_present() is TRUE (1): test-model-sample_mpi.R:4:3empty test (1): test-fit-shared.R:454:1loo cannot be loaded (4): test-fit-mcmc.R:275:3,
  test-fit-mcmc.R:282:3, test-fit-mcmc.R:314:3,
  test-fit-mcmc.R:324:3
• os_is_windows() is TRUE (1): test-install.R:133:3
• os_is_wsl() is TRUE (3): test-install.R:158:3,
  test-model-expose-functions.R:4:1, test-model-methods.R:2:1       
• Sys.getenv("CMDSTANR_OPENCL_TESTS") %in% c("1", "true") is not    
  TRUE (3): test-opencl.R:34:3, test-opencl.R:70:3,
  test-opencl.R:107:3

[ FAIL 0 | WARN 0 | SKIP 13 | PASS 1782 ]

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@jgabry jgabry merged commit 19e7af8 into stan-dev:master Nov 20, 2024
11 checks passed
@jgabry jgabry linked an issue Nov 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with saving model object to a network drive with UNC path
2 participants