Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of libvirt.hw_machine_type #715

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

priteau
Copy link
Member

@priteau priteau commented Oct 17, 2023

We are seeing the following entries in nova-compute.log:

WARNING nova.virt.libvirt.utils [-] Invalid hw_machine_type config value q35

The format for this config option is host-arch=machine-type. For example: x86_64=machinetype1,armv7l=machinetype2.

We are seeing the following entries in nova-compute.log:

    WARNING nova.virt.libvirt.utils [-] Invalid hw_machine_type config value q35

The format for this config option is host-arch=machine-type. For
example: x86_64=machinetype1,armv7l=machinetype2.
@priteau priteau requested a review from darmach October 17, 2023 08:34
@priteau priteau self-assigned this Oct 17, 2023
@priteau priteau requested a review from a team as a code owner October 17, 2023 08:34
Copy link
Member

@darmach darmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting, should we correct also this example in the doc, or is it correct and in openstack image set we should set hw_machine_type to "just" `q35'?

https://docs.openstack.org/nova/latest/admin/hw-machine-type.html#configure

@priteau
Copy link
Member Author

priteau commented Oct 17, 2023

That's interesting, should we correct also this example in the doc, or is it correct and in openstack image set we should set hw_machine_type to "just" `q35'?

https://docs.openstack.org/nova/latest/admin/hw-machine-type.html#configure

I assume the documentation is correct, because the image also has an architecture which can be set via another property.

But when you set the default machine type via nova.conf, the expected format includes the architecture. I assume this is because a hypervisor can support multiple architectures if you are using QEMU with emulation. See https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.hw_machine_type

@mnasiadka mnasiadka merged commit f785b68 into stackhpc/yoga Oct 19, 2023
4 checks passed
@mnasiadka mnasiadka deleted the hw-machine-type branch October 19, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants