Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openstack Logs in Grafana #713

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Openstack Logs in Grafana #713

merged 4 commits into from
Nov 8, 2024

Conversation

technowhizz
Copy link
Contributor

@technowhizz technowhizz commented Oct 13, 2023 •
edited
Loading

This PR contains the dashboard that when combined with the right KA patches, should give you logs in the openstack dashboard

@technowhizz technowhizz self-assigned this Oct 13, 2023
@technowhizz technowhizz changed the base branch from stackhpc/zed to stackhpc/2023.1 March 15, 2024 20:46
@technowhizz technowhizz changed the title WIP: Openstack Logs in Grafana Openstack Logs in Grafana Mar 15, 2024
@technowhizz technowhizz marked this pull request as ready for review March 15, 2024 20:49
@technowhizz technowhizz requested a review from a team as a code owner March 15, 2024 20:49
@markgoddard
Copy link
Contributor

WIP

Is it WIP?

@technowhizz
Copy link
Contributor Author

WIP

Is it WIP?

@markgoddard Updated

@technowhizz technowhizz requested a review from dougszumski March 18, 2024 13:46
@markgoddard
Copy link
Contributor

This PR contains the dashboard that when combined with the right KA patches, should give you logs in the openstack dashboard

Do we have these patches in our antelope fork? What would happen in the dashboard if grafana had been deployed without them?

@technowhizz
Copy link
Contributor Author

This PR contains the dashboard that when combined with the right KA patches, should give you logs in the openstack dashboard

Do we have these patches in our antelope fork? What would happen in the dashboard if grafana had been deployed without them?

We just need one more. If it was deployed without them, one would need to manually configure the opensearch datasource inside the grafana UI for the dashboard to work. Wouldn't break any service deploys or the likes.

@Alex-Welsh
Copy link
Contributor

@technowhizz Is this ready to go in yet? If not, could you link the changes that still need to merge?

@dougszumski
Copy link
Member

I tried testing this, but I get an empty panel:
image

It could be a config error with my env, but I can view logs via the the OpenSearch plugin for Grafana.

This is on master / latest Grafana OSS release. That could also be related.

@technowhizz
Copy link
Contributor Author

This has been fixed now @dougszumski

@dougszumski
Copy link
Member

This is still blocked on the Kolla upstream commit - we need to be better at chasing these on a regular basis

@dougszumski
Copy link
Member

The tweak looks good - works for me now. Thanks

image

@technowhizz
Copy link
Contributor Author

technowhizz commented Jun 28, 2024 •
edited
Loading

I think this can merge now as we have this patch in our KA stackhpc/kolla-ansible#555

@Alex-Welsh
Copy link
Contributor

@dougszumski @technowhizz can we still merge this?

@technowhizz technowhizz merged commit 51b3925 into stackhpc/2023.1 Nov 8, 2024
12 checks passed
@technowhizz technowhizz deleted the logs_in_grafana branch November 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougszumski dougszumski dougszumski approved these changes

Assignees

@technowhizz technowhizz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@technowhizz @markgoddard @Alex-Welsh @dougszumski