Extend the cephadm commands to allow defaults and extras #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technowhizz
requested changes
Oct 9, 2023
MoteHue
force-pushed
the
ceph-mgr-module-enable-prometheus
branch
from
af0099e to
dd2a45d
Compare
MoteHue
changed the title
|
Have made this change, in two commits for transparency. |
MoteHue
force-pushed
the
ceph-mgr-module-enable-prometheus
branch
from
dd2a45d to
0630218
Compare
Alex-Welsh
reviewed
Oct 9, 2023
Co-authored-by: Alex-Welsh <[email protected]>
|
Release note 🙂 |
Alex-Welsh
reviewed
Oct 10, 2023
Co-authored-by: Alex-Welsh <[email protected]>
Alex-Welsh
reviewed
Oct 20, 2023
Co-authored-by: Alex-Welsh <[email protected]>
Alex-Welsh
previously approved these changes
Oct 20, 2023
markgoddard
reviewed
Oct 30, 2023
Co-authored-by: Mark Goddard <[email protected]>
markgoddard
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that in a couple of deployments this was just set by hand. Let's get it automated instead.