Add support for Amphora images in StackHPC Release Train #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
workflows
seunghun1ee
force-pushed
the
amphora-image-release-train
branch
from
882d652 to
062081a
Compare
priteau
requested changes
Dec 20, 2024
| - debootstrap | ||
| - git | ||
| - python3-venv | ||
| - python3-diskimage-builder |
There was a problem hiding this comment.
Why install DIB from packages when we use it from a virtual environment?
|
|
||
| ############################################################################### | ||
| # Octavia Amphora image version | ||
| stackhpc_amphora_image_version: "placeholder" # TODO(seunghun1ee): Test the image |
There was a problem hiding this comment.
Should we keep this for another PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow of Amphora image building, uploading, promoting, downloading, registering were tested.
But the image itself was not.
Opening this PR because workflows are ready to review.