Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amending paths to match Ark #1382

Closed
wants to merge 2 commits into from
Closed

Amending paths to match Ark #1382

wants to merge 2 commits into from

Conversation

jjo93sa
Copy link
Contributor

@jjo93sa jjo93sa commented Nov 22, 2024

  • Treasuredata needs to reference v5 not v4 and the Ark path includes lts
  • RabbitMQ path should reference noarch rather than x86_64

Found during the upgrade of Graphcore CL0 from Antelope to Caracal

@jjo93sa jjo93sa requested a review from a team as a code owner November 22, 2024 09:50
m-bull
m-bull requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjo93sa - just a couple of downstream changes from your config that could do with a clean up please.

etc/kayobe/pulp.yml Outdated Show resolved Hide resolved
etc/kayobe/pulp.yml Outdated Show resolved Hide resolved
etc/kayobe/pulp.yml Outdated Show resolved Hide resolved
@jjo93sa @MoteHue
Amending paths to match Ark
61e102c 
- Treasuredata needs to reference v5 not v4 and the Ark path includes
  `lts`
- RabbitMQ path should reference `noarch` rather than `x86_64`

Found during the upgrade of Graphcore CL0 from Antelope to Caracal
@jjo93sa @MoteHue
Changes as requested
4f2aa0c
@Alex-Welsh Alex-Welsh added bug Something isn't working Caracal Targets the Caracal OpenStack release labels Nov 27, 2024
@MoteHue
Copy link
Contributor

MoteHue commented Dec 12, 2024

Unfortunately it looks like our CI can't handle external contributors, we don't get very many of these. I've pushed to a new branch under my auth here: #1426

Thanks for the fix @jjo93sa! We'll look into fixing external contributions in the future

@MoteHue MoteHue closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull m-bull approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Caracal Targets the Caracal OpenStack release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjo93sa @MoteHue @m-bull @Alex-Welsh