Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: manage the physical interface in ci-aio #1367

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jackhodgkiss
Copy link
Contributor

Treat the physical interface as network interface inside of the ci-aio environment. This is to ensure the network interface files are created correctly with the appropriate permissions otherwise we will lose connection after the DHCP lease expires. Also this approach enables us to include the interface within the firewall configuration ensuring we maintain SSH access through the firewall via this interface.

Treat the physical interface as network interface inside of the `ci-aio` environment. This
is to ensure the network interface files are created correctly with the appropriate permissions
otherwise we will lose connection after the DHCP lease expires. Also this approach enables us
to include the interface within the firewall configuration ensuring we maintain SSH access through
the firewall via this interface.
@jackhodgkiss jackhodgkiss added the bug Something isn't working label Nov 6, 2024
@jackhodgkiss jackhodgkiss self-assigned this Nov 6, 2024
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner November 6, 2024 13:25
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if AIOs are pasing

@jackhodgkiss jackhodgkiss merged commit 875682f into stackhpc/2024.1 Nov 6, 2024
12 checks passed
@jackhodgkiss jackhodgkiss deleted the 2024.1/fix-ci-aio-networking branch November 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants