Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin os-capacity to v0.5 release #1365

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

JohnGarbutt
Copy link
Member

@JohnGarbutt JohnGarbutt commented Nov 5, 2024

Version v0.3 was broken an automatically pulled
on a fresh controller. Lets start pinning this version.

Note v0.5 fixes 842 CVEs vs the previous version:
https://github.com/stackhpc/os-capacity/security/code-scanning

@JohnGarbutt JohnGarbutt requested a review from a team as a code owner November 5, 2024 17:26
@JohnGarbutt JohnGarbutt added the bug Something isn't working label Nov 5, 2024
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's arguably a bugfix, could we aim this at stackhpc/2023.1 first? We'll then merge it up from there.

I'd also prefer it if we could slurp this out to a variable and set it somewhere like stackhpc-monitoring.yml so it's a bit easier to find

Both of those suggestions are easy to do retroactively so if this is a more urgent fix I'm happy to merge now and patch later

@assumptionsandg assumptionsandg changed the base branch from stackhpc/2024.1 to stackhpc/2023.1 November 13, 2024 10:52
@assumptionsandg assumptionsandg force-pushed the bugfix/os-capacity-fix-tag branch from 09b155a to 2421dd1 Compare November 13, 2024 10:55
@Alex-Welsh Alex-Welsh enabled auto-merge (squash) November 13, 2024 15:43
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For future reference, I would normally say we need to have release notes when we change pins but in this case, we're pinning it to the release it's already on so nothing functionally changes.

@Alex-Welsh Alex-Welsh merged commit f21cbf5 into stackhpc/2023.1 Nov 13, 2024
12 checks passed
@Alex-Welsh Alex-Welsh deleted the bugfix/os-capacity-fix-tag branch November 13, 2024 15:44
@priteau priteau mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants