-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Blazar image #1334
Update Blazar image #1334
Conversation
74640bc
to
40476e6
Compare
If it's WIP, I'd rather not merge this into our main branch. Can we wait until it's fully tested? |
I agree with @Alex-Welsh - is there a reason the flavour reservation patches are not merged in stackhpc/2023.1 (or stackhpc/2024.1)? I understand that it's WIP because that needs testing-in-production? |
We're basing this on Blazar master. Maybe @JohnGarbutt has some more context for this. |
If it's based on master - do we plan to switch back to 2023.1 or 2024.1 version later on? That seems like it's going to cause some problems... but I'm not the Blazar expert here. Especially that the container image tag is going to contain 2023.1 - and that's probably confusing. |
@Alex-Welsh I believe this has now been fully tested. @assumptionsandg please do correct me if I am wrong. (All these patches are up for review upstream) The question in my head is what to call the branch in stackhpc/blazar (partly also how to review it). We could call it stackhpc/2023.1 but we really want to use this branch (based on upstream master), with Caracal as well. We could have all the branches point to the same commit for the moment. |
@JohnGarbutt We do this fairly regularly in release train, where we backport changes to our stackhpc/xyz branches. We've got automation set up to keep them up to date we the stable/xyz branches upstream. If there's a change we want in our forks, we should just cherry-pick it into both stackhpc/2023.1 and 2024.1 |
Okay, to get this merge I think we need 2 things:
|
One more thing, could you add to the docs so we know know how to make use of these new features e.g. any changes we should be making in blazar.conf |
b7b386d
to
cb96576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still can't say I love the format but looks good enough to me now
Co-authored-by: Alex-Welsh <[email protected]>
Update Blazar image to include upstream and WIP flavor reservation patches to be used with coral credits.