Add custom rocky dockerfiles #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to workaround the issue: ``` Unable to find a system nic for <MAC_ADDRESS> ``` See: https://askubuntu.com/questions/1400527/unable-to-find-a-system-nic-while-running-cloud-init
This is to support some older raid controllers that were previously supported out of the box in CentOS7.
Assorted changes to rocky-container image
This means that you don't need an internet connection to download the GPG keys. This is useful if you run a local pulp.
* Build OFED from source, to match latest kernel * Tidy up OFED build Co-authored-by: root <[email protected]>
JohnGarbutt
commented
Dec 7, 2022
| [baseos] | ||
| name=Rocky Linux $releasever - BaseOS | ||
| enabled=1 | ||
| baseurl=https://pulp.128-232-222-245.sslip.io/pulp/content/rocky/8.6/BaseOS/x86_64/os/20220914T080246/ |
There was a problem hiding this comment.
This really should somehow be a variable
There was a problem hiding this comment.
Seems like the best way would be if we had build arg support in DIB for the containerfile element?
jovial
reviewed
Dec 7, 2022
| # CentOS 7. We now need an alternative source. Don't leave elrepo installed | ||
| # to avoid installing other packages of unknown providence. | ||
| RUN rpm --import https://www.elrepo.org/RPM-GPG-KEY-elrepo.org \ | ||
| && dnf install -y https://www.elrepo.org/elrepo-release-8.el8.elrepo.noarch.rpm \ |
There was a problem hiding this comment.
possibly we should layer this on top of a more generic image
jovial
approved these changes
Dec 7, 2022
oneswig
reviewed
Dec 9, 2022
| getty.target sys-fs-fuse-connections.mount systemd-logind.service \ | ||
| systemd-remount-fs.service | ||
|
|
||
| RUN curl -L https://www.mellanox.com/downloads/ofed/MLNX_OFED-5.7-1.0.2.0/MLNX_OFED_SRC-5.7-1.0.2.0.tgz --output /tmp/MLNX_OFED_SRC-5.7-1.0.2.0.tgz \ |
There was a problem hiding this comment.
Would be good to parameterise the version of OFED as well
markgoddard
reviewed
Dec 12, 2022
| @@ -0,0 +1,17 @@ | |||
| ======================= | |||
| rocky custom containers | |||
| overcloud_dib_os_element: rocky-container | ||
|
|
||
| overcloud_dib_env_vars_extra: | ||
| DIB_CONTAINERFILE_DOCKERFILE: "{{ source_checkout_path }}/stackhpc-image-elements/elements/rocky-container-pulp/8.5-pulp |
There was a problem hiding this comment.
It would be nice if pulling in this element did this for you
oneswig
reviewed
Dec 13, 2022
|
|
||
| # To build this image you need enable docker build kit. This is for the heredoc support. | ||
|
|
||
| FROM docker.io/library/rockylinux:8 |
There was a problem hiding this comment.
Might need the 8.6 tag instead of the 8 tag?
oneswig
reviewed
Dec 13, 2022
| && cd /tmp \ | ||
| && tar -xzf MLNX_OFED_SRC-5.7-1.0.2.0.tgz \ | ||
| && dnf install -y perl cmake kernel-devel python36-devel perl-generators python36 python3-Cython rpm-build elfutils-libelf-devel zlib-devel gcc-c++ gdb-headless glib2-devel patch lsof libmnl-devel openssl-devel pciutils-devel pkgconf-pkg-config libstdc++-devel libnl3-devel libtool python3-docutils numactl-devel systemd-devel kernel-rpm-macros glibc-devel pciutils gcc valgrind-devel \ | ||
| && /tmp/MLNX_OFED_SRC-5.7-1.0.2.0/install.pl --hypervisor --kernel 4.18.0-372.26.1.el8_6.x86_64 \ |
There was a problem hiding this comment.
Is it possible to figure out the installed kernel version - can we assign a variable for this by running a command in the dockerfile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.