Skip to content

Commit

Permalink
Fix issue removing docker volumes
Browse files Browse the repository at this point in the history
The error response from the docker daemon has changed to:

    Error response from daemon: get opensm_logs: no such volume

This change should support both old and new responses.

Change-Id: Ibef1713d7de2e0a2c6fe046f607b2a8e60dae3da
Closes-Bug: #2050092
(cherry picked from commit 27ece26)
  • Loading branch information
jovial authored and priteau committed May 22, 2024
1 parent e5bd9db commit 0c722dc
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ansible/roles/docker-registry/tasks/destroy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
when: "'/' not in volume"
failed_when:
- volume_result.rc != 0
- "'No such volume' not in volume_result.stderr"
- "'no such volume' not in volume_result.stderr | lower"
vars:
volume: "{{ item.1.split(':')[0] }}"
register: volume_result
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/inspection-store/tasks/destroy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
when: "'/' not in volume"
failed_when:
- volume_result.rc != 0
- "'No such volume' not in volume_result.stderr"
- "'no such volume' not in volume_result.stderr | lower"
vars:
volume: "{{ item.1.split(':')[0] }}"
register: volume_result
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/opensm/tasks/destroy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
when: "'/' not in volume"
failed_when:
- volume_result.rc != 0
- "'No such volume' not in volume_result.stderr"
- "'no such volume' not in volume_result.stderr | lower"
vars:
volume: "{{ item.1.split(':')[0] }}"
register: volume_result
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
Fixes an issue with overcloud service destroy where it failed to remove the
inspection store docker volume. See `LP#2050092
<https://bugs.launchpad.net/kayobe/+bug/2050092>`__.

0 comments on commit 0c722dc

Please sign in to comment.