Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end-to-end chart test template #55

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Fix end-to-end chart test template #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ced40e
Update e2e test with new image tag format
sd109 Nov 1, 2024
de6018e
Add CI test to check default values
sd109 Nov 1, 2024
15af623
Use short sha for image tag
sd109 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ jobs:
- name: Install Helm
uses: azure/setup-helm@v4

- name: Run base chart templating with default values
run: helm template ci-test charts/azimuth-llm

- name: Set up chart testing
uses: helm/chart-testing-action@v2

Expand All @@ -62,13 +65,9 @@ jobs:
# we need to pull these published images and load them into the kind cluster
# with the tag correct tag.
- name: Load tagged container images into kind cluster
run: ./kind-images.sh ${{ github.event.pull_request.head.sha }} ${{ env.CLUSTER_NAME }}
run: ./kind-images.sh $(git rev-parse --short ${{ github.event.pull_request.head.sha }}) ${{ env.CLUSTER_NAME }}
working-directory: web-apps

- name: Add Helm repos for dependencies
run: |
helm repo add stakater https://stakater.github.io/stakater-charts

# https://github.com/helm/charts/blob/master/test/README.md#providing-custom-test-values
# Each chart/ci/*-values.yaml file will be treated as a separate test case with it's
# own helm install/test process.
Expand Down
5 changes: 4 additions & 1 deletion charts/azimuth-llm/templates/test/end-to-end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ spec:
spec:
containers:
- name: gradio-client-test
image: ghcr.io/stackhpc/azimuth-llm-chat-interface:{{ .Values.ui.image.version }}
{{- /*
Use the chat image since we know this contains the gradio_client package
*/}}
image: {{ printf "ghcr.io/stackhpc/azimuth-llm-chat-ui:%s" (default .Chart.AppVersion .Values.ui.image.tag) }}
imagePullPolicy: IfNotPresent
command:
- python
Expand Down
Loading