Update GRUB command line only if parameters change #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grubcmdline role can be invoked like in the following example:
- name: Set iommu=pt
include_role:
name: stackhpc.linux.grubcmdline
vars:
kernel_cmdline:
- iommu=pt
kernel_cmdline_remove:
- ^iommu=
When the role is called multiple times with parameters kernel_cmdline
and kernel_cmdline_remove, each execution moves its kernel parameters at
the end of the command line. This means each full execution would always
update GRUB, even when the end result would be the same.
Fix by comparing the existing command line with the newly generated one
as sets and only updating GRUB_CMDLINE_LINUX_DEFAULT if they are
different.
markgoddard
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grubcmdline role can be invoked like in the following example:
When the role is called multiple times with parameters kernel_cmdline and kernel_cmdline_remove, each execution moves its kernel parameters at the end of the command line. This means each full execution would always update GRUB, even when the end result would be the same.
Fix by comparing the existing command line with the newly generated one as sets and only updating GRUB_CMDLINE_LINUX_DEFAULT if they are different.