Handle missing GRUB_CMDLINE_LINUX_DEFAULT variable #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteau
force-pushed
the
missing-grub-default-cmdline
branch
2 times, most recently
from
9b2d640 to
c98b6c2
Compare
If GRUB_CMDLINE_LINUX_DEFAULT is unset in /etc/default/grub, initialise it from GRUB_CMDLINE_LINUX. We write back the updated kernel command line as GRUB_CMDLINE_LINUX_DEFAULT, the intent being to only apply to normal (non-rescue) boots. However, on RedHat 9.x, the grubby command that runs next still updates GRUB_CMDLINE_LINUX. Fixes #18.
priteau
force-pushed
the
missing-grub-default-cmdline
branch
2 times, most recently
from
866fa7e to
e3620af
Compare
jackhodgkiss
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
GRUB_CMDLINE_LINUX_DEFAULTis unset in/etc/default/grub, initialise it fromGRUB_CMDLINE_LINUX. We write back the updated kernel command line asGRUB_CMDLINE_LINUX_DEFAULT, the intent being to only apply tonormal (non-rescue) boots. However, on RedHat 9.x, the grubby command that runs next still updates GRUB_CMDLINE_LINUX.
Fixes #18.