fix: clicking on notification sends to wrong url #1801
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix of #756, 3: (clicking on notification replies sends you to really old threads)
Updates the value of
url
anditemId
by including incoming payload'surl
anditemId
in the merged payload.The url that was exposed before was of the first unmerged notification, which explains navigating to really old threads
Screenshots
before:
after:
Additional Context
This is part of a series of fixes tracked on #1794
Checklist
Are your changes backwards compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6, incoming payload is received correctly, this just updates the url inside the merged payload. Clicking on a merged notification links to the correct
Item
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
No