fix: iOS notification counts and sums are wacky #1796
Conversation
Soxasora
changed the title
Soxasora
changed the title
There was a problem hiding this comment.
Wow, incredible, we were apparently so close but I didn't realize my naive code to detect iOS in the service worker didn't work.
Reproduced the bug on master (34175ba) with replies and then checked out this branch. Replies don't go 1->2->4 anymore but go 1->2->3. If a reply notification is closed, the next notification will show one less (as expected).
I think the UX is fine since the latest notification now always shows the correct amount of "unread notifications".
The correct sum for "your item stacked X sats" is also very useful. So I suspect we will keep the merging code on iOS but let's see in prod.
Thank you so much again for this simple fix!
| os = event.data.os | ||
| event.waitUntil(storage.setItem('os', event.data.os)) |
There was a problem hiding this comment.
Oh, did simply assigning it to os not work because the service worker does not run in a single scope?
There was a problem hiding this comment.
You guessed it! But only in iOS (drove me nuts for a whole day)
|
Thanks a lot!! I'm trying new strategies for the other issues, I look forward to try and complete what remains ^^ |
Description
Partial fix of #756, 2: (notification counts and sums)
This PR provides immediate relief for iOS users, specifically fixes iOS check to enable ek's fix (
initialValue = 1) giving proper counting and sums on all notificationsosvalue is not updated between events, this fix reliably saves and gets the OS value to/fromServiceWorkerStorageScreenshots
AMOUNT counts
SUM_SATS sums
Additional Context
This is part of a series of fixes tracked on #1794
Checklist
Are your changes backwards compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
9, didn't test
FOLLOWbut it follows (heh) the same counting method as others, tested also with withdraw/deposit sumsFor frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
No