Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #1492 based on #1785, #1787
All failed invoices are returned only once to exactly one client via a new query
failedInvoices
. To avoid an invoice being returned but never retried by a client for any reason, a visibility timeout as described in #1492 (comment) is used: for each returned invoice, we set a newInvoice.lockedAt
column to the current time and then unset it when we can assume that the client did not and will not attempt a retry of this invoice.To not retry invoices that the user manually canceled (closing the QR code), a new boolean column
Invoice.userCancel
was added. This is only set if the invoice was canceled via closing the QR code.TODO:
added
userCancel
column, see #1785client only polls when it has send wallets
added
"cancelledAt" < now() - interval '${WALLET_RETRY_BACKOFF_MS} milliseconds'
filterScreenshots
Additional Context
tbd
Checklist
Are your changes backwards compatible? Please answer below:
tbd
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
tbd
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
tbd
Did you introduce any new environment variables? If so, call them out explicitly here:
tbd