Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt12 dev environment #1702

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Bolt12 dev environment #1702

merged 7 commits into from
Dec 13, 2024

Conversation

riccardobl
Copy link
Member

Description

This solves the first point of #1317 by adding an eclair node as receiver and lndk as sender.

Additional Context

Before deciding to use Eclair, I tried various configurations with CLN as the receiver, connected directly to LND and also with a CLN or LND routing node in between. I couldn’t get it to work reliably with those setups. Eclair, however, worked pretty much out of the box after making a few changes to the bitcoind configuration.

Testing

$ bash sndev cli eclair tipjarshowoffer
<OFFER>

$ bash sndev cli sn_lndk get-invoice <OFFER> 10000
<INVOICE>

$ bash sndev cli sn_lndk pay-invoice <INVOICE-HEX> 10000

Copy link

gitguardian bot commented Dec 12, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Private Key e6e82b0 docker/lndk/tls-key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@riccardobl riccardobl marked this pull request as ready for review December 12, 2024 16:03
@huumn
Copy link
Member

huumn commented Dec 13, 2024

The changes I made:

  • moved eclair, lndk, and cln to wallets docker compose profile which seemed more fitting (and downloads/builds for lndk and eclair are pretty slow)
  • specified x86 platform for lndk (no build support for arm on linux)
  • fixed lndk port conflict with router_lnd

@huumn huumn merged commit 5273494 into stackernews:master Dec 13, 2024
5 of 6 checks passed
@ekzyis ekzyis mentioned this pull request Dec 25, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants