Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-ux: debug tab #727

Merged

Conversation

dustinwloring1988
Copy link
Collaborator

@dustinwloring1988 dustinwloring1988 commented Dec 15, 2024

On Debug tab:
Fixed check for update to get the correct commit for the lastest hash not the hash from the commit.json in the main branch as the latest is after the action that adds the commit
Fixed 'Error: No URL configured' error in local llm status section when entered

333

444

Fixed Check for Update not getting the correct commit
fixed the Local LLM Status not showing BaseURL's
@dustinwloring1988 dustinwloring1988 changed the title UI ux/debug tab ui-ux: debug tab Dec 15, 2024
@dustinwloring1988 dustinwloring1988 added the ui-enhancement Enhancement made to the UI label Dec 15, 2024
@dustinwloring1988
Copy link
Collaborator Author

@thecodacus can you please test this on your setup it work on mine.

@thecodacus
Copy link
Collaborator

thecodacus commented Dec 15, 2024

looks great. tested and works fine. can we have updated from stable branch and main branch ?

@dustinwloring1988
Copy link
Collaborator Author

@thecodacus Yes great idea maybe stable branch by default and a toggle for ('latest' or 'dev')? Should that be a separate PR though, if so I will work on it today as well.

@dustinwloring1988
Copy link
Collaborator Author

or do we want to put in the commit file which branch it is in so it only updates from that one?

@dustinwloring1988
Copy link
Collaborator Author

image

@thecodacus
Copy link
Collaborator

thecodacus commented Dec 15, 2024

or do we want to put in the commit file which branch it is in so it only updates from that one?

wont work as the commit file workflow will always only run on main.. and stable is pulling from main
and we should not change that.

@dustinwloring1988
Copy link
Collaborator Author

dustinwloring1988 commented Dec 15, 2024

@thecodacus Sorry ment to click reply not edit: Yes will work with any branch as the action will write what branch it is in when it dose the commit.json.

@thecodacus
Copy link
Collaborator

thecodacus commented Dec 15, 2024

@thecodacus Sorry ment to click reply not edit: Yes will work with any branch as the action will write what branch it is in when it dose the commit.json.

thats the thing the action will only run on main right ? the stable is only pulling the commit.json from main.. which is how it should be. we should not be creating has on stable branch.

my suggestion is add a time stamp on the commit json. then check commit from both branch and tell the user that the latest if the current timestamp is lower then both the stable and main branch then show the stable branch and mention that there is a newer stable version available.

and if the current time stamp is higher than the stable but lower than the main then show there is a newer nightly version available

now runs on all branches for auto update to work correctly
@dustinwloring1988
Copy link
Collaborator Author

Forgot about that part, now it will run on all.

@thecodacus
Copy link
Collaborator

Forgot about that part, now it will run on all.

don't do that. it will be confusing and will be difficult to identify the version

@dustinwloring1988
Copy link
Collaborator Author

ok I changed it back, I could think of 2 other ways, what are your thoughts:

  1. I could make the branch name a separate action but then that would add even more commits
  2. We could change the branch name manually for now when updating the stable branch

@thecodacus
Copy link
Collaborator

ok I changed it back, I could think of 2 other ways, what are your thoughts:

  1. I could make the branch name a separate action but then that would add even more commits
  2. We could change the branch name manually for now when updating the stable branch

both of these will add commits to stable.

@dustinwloring1988
Copy link
Collaborator Author

with doing that the user would have to specify in the setting and we could just default it to stable?

@thecodacus
Copy link
Collaborator

thecodacus commented Dec 15, 2024

another option is to check the package.json for version. and check the commit hash of that tag if same then its a stable version

tag hash can be found here https://github.com/stackblitz-labs/bolt.diy/blob/{{tag_name}}/app/commit.json

@dustinwloring1988
Copy link
Collaborator Author

Updated Now it will auto set then allow the user to change if they so chose.

@dustinwloring1988 dustinwloring1988 merged commit 4016f54 into stackblitz-labs:main Dec 15, 2024
2 checks passed
@thecodacus
Copy link
Collaborator

this still had names with use infront

@dustinwloring1988
Copy link
Collaborator Author

updating now, thought I got them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-enhancement Enhancement made to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants