-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui-ux: debug tab #727
ui-ux: debug tab #727
Conversation
Fixed Check for Update not getting the correct commit
fixed the Local LLM Status not showing BaseURL's
@thecodacus can you please test this on your setup it work on mine. |
looks great. tested and works fine. can we have updated from stable branch and main branch ? |
@thecodacus Yes great idea maybe stable branch by default and a toggle for ('latest' or 'dev')? Should that be a separate PR though, if so I will work on it today as well. |
or do we want to put in the commit file which branch it is in so it only updates from that one? |
Here is a start to the update by branch
wont work as the commit file workflow will always only run on main.. and stable is pulling from main |
@thecodacus Sorry ment to click reply not edit: Yes will work with any branch as the action will write what branch it is in when it dose the commit.json. |
thats the thing the action will only run on main right ? the stable is only pulling the commit.json from main.. which is how it should be. we should not be creating has on stable branch. my suggestion is add a time stamp on the commit json. then check commit from both branch and tell the user that the latest if the current timestamp is lower then both the stable and main branch then show the stable branch and mention that there is a newer stable version available. and if the current time stamp is higher than the stable but lower than the main then show there is a newer nightly version available |
now runs on all branches for auto update to work correctly
Forgot about that part, now it will run on all. |
don't do that. it will be confusing and will be difficult to identify the version |
ok I changed it back, I could think of 2 other ways, what are your thoughts:
|
both of these will add commits to stable. |
with doing that the user would have to specify in the setting and we could just default it to stable? |
another option is to check the package.json for version. and check the commit hash of that tag if same then its a stable version tag hash can be found here |
if it has not been set by the user yet set it correctly for them
Updated Now it will auto set then allow the user to change if they so chose. |
this still had names with |
updating now, thought I got them |
On Debug tab:
Fixed check for update to get the correct commit for the lastest hash not the hash from the commit.json in the main branch as the latest is after the action that adds the commit
Fixed 'Error: No URL configured' error in local llm status section when entered