Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search chats support #440

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

SujalXplores
Copy link

📝 PR Checklist

  • Branch from the main branch
  • Update documentation if needed
  • Manually verify all new functionality works as expected
  • Keep PRs focused and atomic

This pull request includes several changes to the Menu component in the sidebar directory, focusing on adding a search filter functionality and improving the user interface. The most important changes include importing and utilizing a new useSearchFilter hook, modifying the Menu component to include a search input, and updating the display logic for the list of items.

Enhancements to the Menu component:

New hook implementation:

  • app/lib/hooks/useSearchFilter.ts: Added a new useSearchFilter hook that provides search functionality with debouncing. It filters items based on a search query and specified search fields.

Before:

image

After:

image

@SujalXplores
Copy link
Author

@wonderwhy-er @chrismahoney Please review this PR

@wonderwhy-er
Copy link
Collaborator

@SujalXplores hey there, I am sadly bit busy this week, I may be bit absent till Monday. Sorry.
Will take a look as soon as time allows

Copy link
Collaborator

@thecodacus thecodacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dustinwloring1988
Copy link
Collaborator

worked for me. Great addition thanks

@thecodacus thecodacus merged commit 02f4de4 into stackblitz-labs:main Nov 29, 2024
1 check passed
@SujalXplores SujalXplores deleted the feat/search-chats branch November 30, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants