Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve sidebar #422

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

SujalXplores
Copy link

This pull request includes several changes to improve the sidebar components and the tooltip functionality. The most important changes include removing unnecessary state and event handling in the HistoryItem component, enhancing the Tooltip component with additional properties, and updating class names for better styling.

Sidebar Component Improvements:

Before:

After:

Tooltip Component Enhancements:

  • app/components/ui/Tooltip.tsx: Added new properties (position, maxWidth, delay) to the TooltipProps interface for better customization. Updated the WithTooltip component to use these new properties and improved the styling. [1] [2]

Before:

After:

@SujalXplores
Copy link
Author

@chrismahoney @wonderwhy-er could you please review this PR?

@wonderwhy-er
Copy link
Collaborator

Looks good, I think I kinda liked that tooltop was white with black triangle before. Looked more interesting.
Why you made it grey?

@SujalXplores
Copy link
Author

Looks good, I think I kinda liked that tooltop was white with black triangle before. Looked more interesting. Why you made it grey?

@wonderwhy-er Thank you for the feedback! I made the tooltip background match the theme colors (grey in dark mode) to maintain consistency with our design and improve accessibility. The white tooltip in dark mode created a high contrast that could be jarring for users, especially in low-light conditions.

However, I understand your point about the visual interest of the white/black combination. If you feel strongly about keeping that design, I'm happy to revert back to white

What do you think?

@wonderwhy-er
Copy link
Collaborator

Ouh, my bad I do not test with black mode, I use white one.
If it was white in black mode you are right, we can adjust style better later.
Let's merge.

@wonderwhy-er wonderwhy-er merged commit d41a4ac into stackblitz-labs:main Nov 26, 2024
1 check passed
@SujalXplores SujalXplores deleted the feat/improve-sidebar branch November 26, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants