Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedrock support added #357

Closed
wants to merge 3 commits into from
Closed

Conversation

dhairya13703
Copy link

No description provided.

@wonderwhy-er
Copy link
Collaborator

There is already PR for badrock here
#324

And it hit an issue where bedrock will be shown but there is no way to set it up in client.
Aka client ui for now allows only setting up api key.
Bedrock requires more parameters.

I did give it a try to fix in number of ways.
But its bit tricky.

I think I will give it a try later myself.

  1. Seems like we need to make provider in the list dependant on presence of API keys on server for now.

  2. Or, allow more complex UI for some providers that allows to add more then just field in UI/API key settings.

Both are bit tricky refactors.

I don't really want to show not working providers on client if API key was not set for them on server and is not possible to set from client.

@dhairya13703
Copy link
Author

Okay got it. But we can do it like if we we select amazon bedrock we will have more parameters so that way user can enter it.

@wonderwhy-er
Copy link
Collaborator

Seems like you are pushing more things in same branch that are unrelated.
Should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants