-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance prompt #325
base: main
Are you sure you want to change the base?
enhance prompt #325
Conversation
it removes invalid provider error |
Looks to be a duplicate line;
No error after removing the second one. |
Thanks @svajagan! @kustomzone are you saying you had to tweak it before getting it to work? |
Line's been removed. Haven't tested further as not using providers. |
This worked for me via Ollama just fine, I'd ask the group @coleam00 @wonderwhy-er @emcconnell if you're able to test with other providers. Seems like it was just a leftover from the provider refactor and needed |
I'd love to see this fixed |
@iamvanca Does this mean you could just change provider.name to "provider?.name || provider"? So it would use provider.name only if it exists, otherwise go back to just using provider? Maybe I'm off track here, let me know! |
enhance prompt