Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance prompt #325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

enhance prompt #325

wants to merge 4 commits into from

Conversation

svajagan
Copy link

enhance prompt

@svajagan
Copy link
Author

it removes invalid provider error

@kustomzone
Copy link

Looks to be a duplicate line;

enhancePrompt={() => {
     enhancePrompt={() => {

No error after removing the second one.

@coleam00
Copy link
Collaborator

Thanks @svajagan! @kustomzone are you saying you had to tweak it before getting it to work?

@kustomzone
Copy link

kustomzone commented Nov 18, 2024

Line's been removed. Haven't tested further as not using providers.

@chrismahoney
Copy link
Collaborator

This worked for me via Ollama just fine, I'd ask the group @coleam00 @wonderwhy-er @emcconnell if you're able to test with other providers. Seems like it was just a leftover from the provider refactor and needed provider?.name updated.

@chrismahoney chrismahoney added the bug Something isn't working label Nov 19, 2024
@chrismahoney chrismahoney self-assigned this Nov 19, 2024
@chrismahoney
Copy link
Collaborator

I'd love to see this fixed

@chrismahoney chrismahoney self-requested a review November 19, 2024 05:29
@iamvanca
Copy link

Hi,
I have discovered that if you add .name after provider in Chat.client.tsx (see attached image), it works with OpenRouter and OpenAI models but not with Anthropic models if you select Anthropic as a provider.
If you select OpenRouter as a provider it works with Anthropic models.
These are the only providers I have tested.
enhance prompt

@itsmebcc
Copy link

Hi, I have discovered that if you add .name after provider in Chat.client.tsx (see attached image), it works with OpenRouter and OpenAI models but not with Anthropic models if you select Anthropic as a provider. If you select OpenRouter as a provider it works with Anthropic models. These are the only providers I have tested. enhance prompt

This worked for me using Ollama

@coleam00
Copy link
Collaborator

@iamvanca Does this mean you could just change provider.name to "provider?.name || provider"? So it would use provider.name only if it exists, otherwise go back to just using provider? Maybe I'm off track here, let me know!

@dustinwloring1988 dustinwloring1988 added the question Further information is requested label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants