feat: improve IndexedDB persistence handling #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the IndexedDB persistence handling in the app, making it more reliable and robust. Key improvements include better browser environment detection, database verification, improved error handling, and proper cleanup processes. While the persistence works best in Safari, Chrome-specific issues are handled gracefully. Changes: - Add better browser environment detection - Add database verification and testing - Improve error handling and logging - Add proper cleanup process - Make persistence work reliably in Safari - Handle Chrome-specific issues gracefully - Add better state tracking and management Note: For the best experience with persistence features, use Safari browser.
The orange indicator light wasn't being cleared after saving a file because the file wasn't being removed from the modifiedFiles set. This change ensures that when a file is saved: 1. It's removed from unsavedFiles set 2. It's removed from modifiedFiles set This fixes the issue where the orange indicator light would stay on even after saving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the IndexedDB persistence handling in the app, making it more reliable and robust. Key improvements include better browser environment detection, database verification, improved error handling, and proper cleanup processes. While the persistence works best in Safari, Chrome-specific issues are handled gracefully.
Changes:
Add better browser environment detection
Add database verification and testing
Improve error handling and logging
Add proper cleanup process
Make persistence work reliably in Safari
Handle Chrome-specific issues gracefully
Add better state tracking and management
Note: For the best experience with persistence features, use Safari browser.