Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify local start - remove pnpm from preview script, make it work on Windows and not fail due to bindings #106

Closed
wants to merge 2 commits into from
Closed

fix: simplify local start - remove pnpm from preview script, make it work on Windows and not fail due to bindings #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfef52
Try to fix start for windows
wonderwhy-er Oct 28, 2024
2cf1de8
Improve scripts
wonderwhy-er Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
"test:watch": "vitest",
"lint": "eslint --cache --cache-location ./node_modules/.cache/eslint .",
"lint:fix": "npm run lint -- --fix",
"start": "bindings=$(./bindings.sh) && wrangler pages dev ./build/client $bindings --ip 0.0.0.0 --port 3000",
"typecheck": "tsc",
"start:windows": "wrangler pages dev ./build/client",
"start:unix": "bindings=$(./bindings.sh) && wrangler pages dev ./build/client $bindings",
"start": "node -e \"const { spawn } = require('child_process'); const isWindows = process.platform === 'win32'; const cmd = isWindows ? 'npm run start:windows' : 'npm run start:unix'; const child = spawn(cmd, { shell: true, stdio: 'inherit' }); child.on('exit', code => process.exit(code));\"", "typecheck": "tsc",
"typegen": "wrangler types",
"preview": "pnpm run build && pnpm run start"
"preview": "npm run build && npm run start"
},
"engines": {
"node": ">=18.18.0"
Expand Down
Loading