Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 2.1.1, 3.0.1 #415

Merged
merged 14 commits into from
Oct 20, 2023
Merged

New version 2.1.1, 3.0.1 #415

merged 14 commits into from
Oct 20, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 16, 2023

Description

  • added new versions 2.1.1, 3.0.1
  • removed versions 1.3.2, 1.4.1, 1.4.2, 1.5.1, 1.5.3, 2.0.1

@sbernauer pointed out that there is a breaking change apache/superset#24262

Tests worked locally, i will see what has to be done here.

#416

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@maltesander maltesander requested a review from a team October 16, 2023 11:27
@maltesander maltesander self-assigned this Oct 16, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@maltesander maltesander changed the title New version 2.1.1, 3.0.0 New version 2.1.1, 3.0.1 Oct 19, 2023
@maltesander
Copy link
Member Author

@maltesander maltesander requested a review from a team October 19, 2023 11:14
@maltesander maltesander requested a review from sbernauer October 20, 2023 08:19
@sbernauer
Copy link
Member

LGTM, but please mention in the changelog that you fixed the configOverrides taking precedence

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@maltesander
Copy link
Member Author

@maltesander maltesander added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 448ff8b Oct 20, 2023
29 checks passed
@maltesander maltesander deleted the new-version-2.1.1-3.0.0 branch October 20, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants