Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Rust and Go dependencies #307

Merged
merged 13 commits into from
Jul 15, 2024
Merged

chore: Bump Rust and Go dependencies #307

merged 13 commits into from
Jul 15, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jul 11, 2024

Part of stackabletech/issues#557

Reviewer

Preview Give feedback

@Techassi
Copy link
Member

Hint: The cargo udeps error is caused by an outdated cargo-udeps version. Bumping the version used should fix the issue, see stackabletech/operator-rs#804 for additional details.

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jul 12, 2024

Hint: The cargo udeps error is caused by an outdated cargo-udeps version. Bumping the version used should fix the issue, see stackabletech/operator-rs#804 for additional details.

Thanks. I'll update it, but first I want to see what happens if I only update the rust-toolchain in CI. I have a sneaking suspicion that it will just work. It didnt't work 😅

@NickLarsenNZ
Copy link
Member Author

Should I include go updates in this too?
And is there anything else to consider ahead of the release?

@Techassi
Copy link
Member

Should I include go updates in this too?

Yes, we can update those as well. They might get a little tricky due to the FFI/cgo stuff.

And is there anything else to consider ahead of the release?

Nothing I can think of.

@Techassi Techassi changed the title chore: Bump dependencies chore: Bump Rust and Go dependencies Jul 15, 2024
@Techassi Techassi marked this pull request as ready for review July 15, 2024 09:55
Copy link
Member Author

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have tested installing a stack and listing the stacklets. 🚀

@Techassi Techassi added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit e96139a Jul 15, 2024
39 checks passed
@Techassi Techassi deleted the bump-deps branch July 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants