feat: Add labels to deployed dynamic objects #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds /demos and /stacks folder to gitignore. These folders can be used to create local-only demo and stack tests. It also removed the (accidentally) published demo files.
Techassi
force-pushed
the
feat/labels
branch
from
c465f5b to
6af959c
Compare
This was referenced Dec 18, 2023
|
TODO: Remove any unwraps, final code clean-up. |
Techassi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by #148, part of stackabletech/issues#188
This adds labels to all deployed
DynamicObjects. The implementation is a little messy and requires some internal restructuring to accommodate future changes. Code should be split into more sub-crates. A high-level overview might look something like this: