Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FFI/cgo string passing #133

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix: FFI/cgo string passing #133

merged 9 commits into from
Nov 6, 2023

Conversation

Techassi
Copy link
Member

Fixes #131, implementation details are here.

@Techassi
Copy link
Member Author

As suspected, this needs further work to make MacOS builds compile again.

@Techassi
Copy link
Member Author

Compiles again!

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM otherwise

rust/helm-sys/src/lib.rs Show resolved Hide resolved
@Techassi Techassi requested a review from sbernauer November 3, 2023 12:21
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Techassi Techassi added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 764757b Nov 6, 2023
39 checks passed
@Techassi Techassi deleted the fix/ffi-cgo branch November 6, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation of 3rd party helm charts fails sporadically
2 participants